Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fix always true condition #4590

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix: fix always true condition #4590

merged 1 commit into from
Mar 24, 2022

Conversation

XhmikosR
Copy link
Contributor

References

user is checked at the top of the changeOwners function so it shouldn't be falsy here.

@XhmikosR XhmikosR marked this pull request as ready for review March 19, 2022 20:18
@XhmikosR XhmikosR requested a review from a team as a code owner March 19, 2022 20:18
@wraithgar
Copy link
Member

chore is reserved for things that don't affect the published module, so this would be a fix.

@XhmikosR XhmikosR changed the title chore: fix always true condition fix: fix always true condition Mar 21, 2022
@XhmikosR
Copy link
Contributor Author

@wraithgar same here please :)

@wraithgar
Copy link
Member

wraithgar commented Mar 21, 2022

@fritzy heads up this is a single commit so when you squash it, it will still try to chose the commit and not the PR title

@fritzy fritzy merged commit f4f933e into npm:latest Mar 24, 2022
fritzy pushed a commit that referenced this pull request Mar 24, 2022
@XhmikosR XhmikosR deleted the patch-1 branch March 24, 2022 16:40
@lukekarrys lukekarrys mentioned this pull request Mar 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants